chore: release 5.6.1-at modal detecting utils#157
Closed
rohitsahu-bstack wants to merge 5 commits into
Closed
Conversation
rohitsahu-bstack
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds modal detection utilities to the core utils module as part of a 5.6.1-at release. The changes introduce functionality to detect modal dialogs on a webpage using both definitive modal attributes and heuristic-based detection for elements that appear modal-like.
- Adds two new utility functions for modal detection:
detectModalStackandgetOverlayFromStack - Implements both definitive modal detection (via ARIA attributes and dialog elements) and heuristic detection (based on element size and positioning)
- Exports the new utilities through the main utils index file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/core/utils/index.js | Exports the two new modal detection utilities |
| lib/core/utils/detect-modal-stack.js | Main modal detection function that finds both definitive and potential modals |
| lib/core/utils/get-overlay-from-stack.js | Helper function to check if an element appears to be a modal overlay based on size and positioning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mattscepter
approved these changes
Sep 17, 2025
Collaborator
Author
|
closing as this got merged as part of 5.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<< Describe the changes >>
Closes: